[receiver/hostmetrics] Migrate memory scraper to the new metrics builder #7421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @rogercoll, thanks for the contribution! There is already an open PR for this scraper #7312 We can see if this one can be merged first. If you want to convert any other scraper please check that no one is working on a sub-issue made for the scraper here open-telemetry/opentelemetry-collector#10904 |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
from
0154e6a to
2b86ffc
Compare
|
@dmitryax Thanks for the information, I didn't check correctly the memory scraper update in open-telemetry/opentelemetry-collector#10904. |
|
@rogercoll please resolve linter issues |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
from
a8a5646 to
afe2d3b
Compare
|
@dmitryax Linter issues should be fixed by now. |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
2 times, most recently
from
7b69174 to
326fbc2
Compare
anuraaga
approved these changes
Feb 2, 2022
Closed
5 tasks
|
@rogercoll please rebase your PR. codegen.go was moved to doc.go |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
from
6ca2534 to
4d6f019
Compare
|
@dmitryax PR rebased Regards |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
from
4d6f019 to
f793624
Compare
|
Linter is failing |
rogercoll
force-pushed
the
experimental_metrics_builder_memory
branch
from
f793624 to
a551925
Compare
|
Closing as #7312 was merged |
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
This updates: - the milestone to match "next release" - the token to use otel bot's token - context.issue.number --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: open-telemetry/opentelemetry-collector#10904